Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Apr 25, 2025


PR-Codex overview

This PR focuses on enhancing the FloatingChat component by renaming it to NebulaChatButton, adding a new support page type, and updating related components and imports to accommodate this change.

Detailed summary

  • Renamed NebulaFloatingChatButton to NebulaChatButton.
  • Added support as a new pageType option in various components.
  • Updated imports and usage of NebulaChatButton in multiple files.
  • Introduced isFloating prop for NebulaChatButton.
  • Modified the SupportPage to include the new NebulaChatButton for support inquiries.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Apr 25, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners April 25, 2025 18:10
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: 7087b3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 7:41pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 25, 2025 7:41pm
login ⬜️ Skipped (Inspect) Apr 25, 2025 7:41pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 25, 2025 7:41pm
wallet-ui ⬜️ Skipped (Inspect) Apr 25, 2025 7:41pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 25, 2025
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (bb554e5) to head (7087b3f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6862   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 225 ms (+237.71% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 357 ms (+96.36% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 88 ms (+1708.67% 🔺) 201 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 37 ms (+1241.67% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 110 ms (+907.58% 🔺) 497 ms

@GiselleNessi GiselleNessi added the merge-queue Adds the pull request to Graphite's merge queue. label Apr 25, 2025
Copy link
Contributor Author

GiselleNessi commented Apr 25, 2025

Merge activity

  • Apr 25, 2:19 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 25, 3:26 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 25, 3:34 PM EDT: MananTank added this pull request to the Graphite merge queue.
  • Apr 25, 3:42 PM EDT: Merged by the Graphite merge queue.

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 19:21 Inactive
@MananTank MananTank changed the title adding new cta in support page/ nebula modal Dashboard: add nebula chat on support page Apr 25, 2025
@MananTank MananTank changed the title Dashboard: add nebula chat on support page Dashboard: add nebula chat on support page, update CTAs Apr 25, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 19:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 19:23 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 19:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 19:23 Inactive
@MananTank MananTank removed the merge-queue Adds the pull request to Graphite's merge queue. label Apr 25, 2025
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `FloatingChat` component by renaming it to `NebulaChatButton` and adding support for a new `support` page type. It also updates various components and their usage across the application to reflect this change.

### Detailed summary
- Renamed `NebulaFloatingChatButton` to `NebulaChatButton`.
- Added `support` as a new value for the `pageType` property.
- Updated imports and component usage to reflect the new name.
- Added `isFloating` prop to `NebulaChatButton`.
- Modified `SupportPage` to utilize `NebulaChatButton` for support inquiries.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the gi/add-nebula-support-cta branch from 851903c to 7087b3f Compare April 25, 2025 19:34
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 19:34 Inactive
@graphite-app graphite-app bot merged commit 7087b3f into main Apr 25, 2025
23 checks passed
@graphite-app graphite-app bot deleted the gi/add-nebula-support-cta branch April 25, 2025 19:42
@vercel vercel bot temporarily deployed to Production – login April 25, 2025 19:42 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 25, 2025 19:42 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 25, 2025 19:42 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 25, 2025 19:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants